Skip to content

Conversation

@llinq
Copy link

@llinq llinq commented Feb 9, 2026

MR relates to #965

@netomi
Copy link
Contributor

netomi commented Feb 9, 2026

can you sign the ECA as explained here: https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1598

@llinq
Copy link
Author

llinq commented Feb 9, 2026

Hello, done @netomi, thanks for reply :)

@netomi
Copy link
Contributor

netomi commented Feb 9, 2026

@gnugomez could you take a look?

Copy link
Contributor

@gnugomez gnugomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llinq what's the intention of this patch?

I don't really see any visual difference by applying your changes.

@llinq
Copy link
Author

llinq commented Feb 11, 2026

@gnugomez this change expands the clickable area of the mobile menu link to cover the entire list item.

Currently, only the label itself is clickable, which makes interaction harder (especially on mobile devices). With this update, the whole list item becomes clickable, significantly improving usability and touch accessibility.

This change was motivated by issue #965 which appears to be directly related to this behavior.

Before (current behavior) After (with this change)

@gnugomez
Copy link
Contributor

gnugomez commented Feb 11, 2026

gotcha @llinq , I now see the benefit, although it doesn’t fully solve the issue. Adding a width of 100% is a somewhat clumsy solution, and the corners are still not working correctly, plus you are not fixing the logout form. I believe that the best approach here would be to use MUI Component prop.

@gnugomez
Copy link
Contributor

@llinq could you add me to your fork so that I can push the changes?

@llinq
Copy link
Author

llinq commented Feb 11, 2026

Hi @gnugomez, I agree with your suggestion, thanks!
I’ve sent you the invitation, let me know if I can help with anything else.

@gnugomez gnugomez force-pushed the style/improve-mobile-menu-usability branch from 9d59cb2 to 353ba56 Compare February 11, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants