-
Notifications
You must be signed in to change notification settings - Fork 285
fix(webui): improve mobile menu item link styling for better usability #1598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Joao Costa <joaopedrocosta.contato@gmail.com>
…com/llinq/openvsx into style/improve-mobile-menu-usability
|
can you sign the ECA as explained here: https://api.eclipse.org/git/eca/status/gh/eclipse/openvsx/1598 |
|
Hello, done @netomi, thanks for reply :) |
|
@gnugomez could you take a look? |
gnugomez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llinq what's the intention of this patch?
I don't really see any visual difference by applying your changes.
|
@gnugomez this change expands the clickable area of the mobile menu link to cover the entire list item. Currently, only the label itself is clickable, which makes interaction harder (especially on mobile devices). With this update, the whole list item becomes clickable, significantly improving usability and touch accessibility. This change was motivated by issue #965 which appears to be directly related to this behavior.
|
|
gotcha @llinq , I now see the benefit, although it doesn’t fully solve the issue. Adding a width of 100% is a somewhat clumsy solution, and the corners are still not working correctly, plus you are not fixing the logout form. I believe that the best approach here would be to use MUI Component prop. |
|
@llinq could you add me to your fork so that I can push the changes? |
|
Hi @gnugomez, I agree with your suggestion, thanks! |
9d59cb2 to
353ba56
Compare


MR relates to #965