Pipelining depth grows unbounded when prepared statement is retried with explicit parameter types#1646
Merged
tsegismont merged 8 commits intoMay 19, 2026
Conversation
Signed-off-by: doxlik <doxlikx@gmail.com>
tsegismont
requested changes
Apr 9, 2026
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @doxlik
Can you please add a test (that does not pass without the fix)
Contributor
Author
|
@tsegismont done! |
tsegismont
reviewed
May 13, 2026
Member
There was a problem hiding this comment.
Thanks for the update @doxlik
I think there are a couple of issues with this test. First, it extends PreparedStatementTestBase, so it executes all tests defined in this class, which is not necessary. Then I'd rather have a simpler test here: we want to make sure inflight is never negative, so perhaps we could make the field visible for testing or add an assertion.
Signed-off-by: doxlik <doxlikx@gmail.com>
Signed-off-by: doxlik <doxlikx@gmail.com>
Signed-off-by: doxlik <doxlikx@gmail.com>
Contributor
Author
|
@tsegismont good points. Done! |
doxlik
changed the title
tsegismont
approved these changes
May 19, 2026
Member
tsegismont
left a comment
tsegismont
left a comment
There was a problem hiding this comment.
Thank you @doxlik , this looks good to me.
…SocketConnectionBase.java
Member
|
@doxlik when this is merged, I'll take care of backporting |
tsegismont
changed the title
tsegismont
added a commit
that referenced
this pull request
May 19, 2026
…ith explicit parameter types (#1646) (#1667) * Increment inflight counter on prepare-with-parametes-types query * test * Fix prepared statement reprepare inflight accounting * Fix prepared statement reprepare inflight accounting * Fix prepared statement reprepare inflight accounting * Update vertx-sql-client-codec/src/main/java/io/vertx/sqlclient/codec/SocketConnectionBase.java --------- Signed-off-by: doxlik <doxlikx@gmail.com> Co-authored-by: doxlik <168666511+doxlik@users.noreply.github.com>
tsegismont
added a commit
that referenced
this pull request
May 19, 2026
…ith explicit parameter types (#1646) (#1668) * Increment inflight counter on prepare-with-parametes-types query * test * Fix prepared statement reprepare inflight accounting * Fix prepared statement reprepare inflight accounting * Fix prepared statement reprepare inflight accounting * Update vertx-sql-client-codec/src/main/java/io/vertx/sqlclient/codec/SocketConnectionBase.java --------- Signed-off-by: doxlik <doxlikx@gmail.com> Co-authored-by: doxlik <168666511+doxlik@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1644