Closed
Conversation
Supports keep alive configuration parameters in client base.
|
@vietj I've seen we are going to add this to version 5. Can we also please add it to 4.X? |
Member
|
@vealrad you PR seems to do more than setting TCP timeout unlike these PR : https://github.com/eclipse-vertx/vert.x/pull/5913/changes and https://github.com/eclipse-vertx/vert.x/pull/5962/changes I will backport the master PR to 5.x, can you provide a separate PR for the extra changes done in this PR instead ? |
|
@vietj Yes, I will provide a separate PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to control the TCP_USER_TIMEOUT value provided by Netty, this setting has been passed from TCP base in NetServer context.
To be able to control keepalive parameters already present in NetServer context in NetClient, these settings have been passed in NetClient context.