Added break request support to Device CDC ACM#248
Merged
fdesbiens merged 2 commits intoeclipse-threadx:devfrom Mar 5, 2026
Merged
Added break request support to Device CDC ACM#248fdesbiens merged 2 commits intoeclipse-threadx:devfrom
fdesbiens merged 2 commits intoeclipse-threadx:devfrom
Conversation
ayedm1
changed the title
ayedm1
force-pushed
the
cdc_acm_device_break_req
branch
from
342498e to
b50aca0
Compare
rahmanih
reviewed
Feb 9, 2026
Comment on lines
+73
to
+74
| /* resulting in version 6.1.12 */ | ||
| /* 01-28-2026 Mohamed AYED Modified comment(s), */ |
Contributor
There was a problem hiding this comment.
no need for such a comment, please remove it.
ayedm1
force-pushed
the
cdc_acm_device_break_req
branch
2 times, most recently
from
bbdb12f to
a98ff10
Compare
- Implements handling of UX_SLAVE_CLASS_CDC_ACM_SEND_BREAK in the CDC ACM control request path. - Ensures break state is cleared on class deactivation to avoid carrying state across disconnect/reset cycles. - Minor comment/whitespace cleanups in touched headers/sources. - Testing: Build-only / compilation sanity/send break request. (no new automated tests added).
ayedm1
force-pushed
the
cdc_acm_device_break_req
branch
from
a98ff10 to
6ad1351
Compare
Contributor
|
@rahmanih, is this one ready for merging, or do you want additional changes to be made? |
Contributor
|
Under validation, I'll update the status by tomorrow. |
rahmanih
approved these changes
Mar 5, 2026
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
works like a charm 🥇
Approved!
Contributor
|
@fdesbiens, |
fdesbiens
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referance:
Universal Serial Bus Communications Class Subclass Specification for PSTN Devices