Device MSC: add START STOP (load/eject) request support#246
Merged
fdesbiens merged 2 commits intoeclipse-threadx:devfrom Mar 3, 2026
Merged
Device MSC: add START STOP (load/eject) request support#246fdesbiens merged 2 commits intoeclipse-threadx:devfrom
fdesbiens merged 2 commits intoeclipse-threadx:devfrom
Conversation
Merging changes ahead of hotfix release 202504a
rahmanih
requested changes
Feb 9, 2026
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
Hi,
could you please make this PR cover the "START/STOP request support" only, and undo all the cosmetics changes, that can be done in a separate PR.
ayedm1
force-pushed
the
device_storage_load_eject_media
branch
2 times, most recently
from
a773faa to
e28b1dd
Compare
- Add mass-storage “removable media” support by tracking per-LUN prevent/allow medium removal and loaded/ejected status. - Introduce an optional per-LUN callback to handle SCSI START STOP UNIT (including load/eject and power-condition fields). - Extend storage constants (media types, sense keys/codes, power conditions, prevent flags) to support the new behavior and improve readability (explicit hex values). - Initialize new per-LUN state on activation (default: medium removal allowed, medium loaded) and wire the new callback through storage initialization. - Includes minor formatting/comment cleanups and version banner updates to 6.4.6. SCSI Block Commands – 4 (SBC-4)
ayedm1
force-pushed
the
device_storage_load_eject_media
branch
from
e28b1dd to
8cdbb7c
Compare
Contributor
Author
cosmetics changes, reverted |
Contributor
|
Is this ready to merge, @rahmanih? |
Contributor
|
@fdesbiens |
rahmanih
approved these changes
Mar 3, 2026
Contributor
rahmanih
left a comment
rahmanih
left a comment
There was a problem hiding this comment.
Tested on Windows and Linux and it works as expected.
approved 💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PREVENT ALLOW MEDIUM REMOVAL command:
START STOP UNIT command: