Skip to content

Conversation

@danielpeintner
Copy link
Member

fixes #1301

@danielpeintner
Copy link
Member Author

danielpeintner commented Mar 13, 2025

The code style issues should be resolved once #1362 is merged.

Anyhow, I noticed one more thing about the browser example that no longer work.
e.g., examples/browser/index.html

EDIT: Just a local issue on my side 🙈

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a little bit the versions and I found out that we already published a deprecation message in 0.8.x (see https://www.npmjs.com/package/@node-wot/td-tools/v/0.8.16). So I think that given the current versioning approach that we are using ( minor increase ~= major increase), we should have already removed it. Therefore I would go ahead with this PR 👍🏻

@relu91
Copy link
Member

relu91 commented Mar 13, 2025

btw, should we also deprecate the package in npm? I think so.
image

@danielpeintner
Copy link
Member Author

danielpeintner commented Mar 14, 2025

btw, should we also deprecate the package in npm?

Yes, I did set it as deprecated now.

see https://www.npmjs.com/package/@node-wot/td-tools

@relu91 relu91 merged commit ecbeaa5 into eclipse-thingweb:master Mar 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODOs after major release

2 participants