Re-subscribe on event/observed property error #34
+101
−110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hi @pierre-josselin , thank you for the fix. It makes sense and I like it and would merge the PR. However, you need to sign your commits and link your GitHub account to your Eclipse account (which you need to create). You will probably need to reopen your PR as the commits are already online. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a proposed fix related to this node-wot issue.
Subscriptions (subscribeEvent & observeProperty) expire after X minutes (under some conditions?) because the HTTP request times out.
More generally, this pull request attempts to automatically restart a failed subscription every second. Like the "repeat" mechanism you initially implemented, but extended to errors occurring after a successful subscription.
Tested on Node-RED 4.1.2.