[1771] Add API to customize help text on the detail view #1782
+184
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcharfadi
force-pushed
the
mch/enh/detail-helpText
branch
4 times, most recently
from
24e566d to
64d60b9
Compare
mcharfadi
force-pushed
the
mch/enh/detail-helpText
branch
from
64d60b9 to
bc395dc
Compare
AxelRICHARD
reviewed
Dec 31, 2025
Member
AxelRICHARD
left a comment
AxelRICHARD
left a comment
There was a problem hiding this comment.
I will fix the comments myself, rebase and merge the PR.
Thank you!
| - In diagrams, an _items_ compartment is now available on `PortDefinition` graphical nodes to display `ItemUsage`. | ||
| - In diagrams, an `ItemUsage` graphical border node is now available on `PortDefinition` graphical nodes. | ||
| - In diagrams, when creating an element from a compartment, it will not be displayed by default on the diagram, but only in the compartment. | ||
| - In the advanced property view, __isComposite__ and __isReference__ checkboxes now have a help text. |
Member
There was a problem hiding this comment.
In the advanced property view, isComposite and isReference checkboxes now have a help text. => In the Advanced tab of the Details view, isComposite and isReference properties (checkboxes widgets) now have a help text.
| * @author mcharfadi | ||
| */ | ||
| @Service | ||
| public class IsCompositeIsReferenceDetailViewHelpTextProvider implements IDetailViewHelpTextProvider { |
Member
There was a problem hiding this comment.
Detail => Details with an s (always)
| * | ||
| * @author mcharfadi | ||
| */ | ||
| public interface IDetailViewHelpTextProvider { |
Member
There was a problem hiding this comment.
Detail => Details with an s (always)
| import org.eclipse.syson.sysml.Element; | ||
|
|
||
| /** | ||
| * Provides custom Help text for the detail view widgets. |
Member
There was a problem hiding this comment.
detail => details with an s (always)
| .then(requestIsPortionHelpText) | ||
| .thenCancel() | ||
| .verify(Duration.ofSeconds(10)); | ||
|
|
| assertThat(helpText).isEmpty(); | ||
| }; | ||
|
|
||
|
|
| precondition.setPredicateExpression("aql:not(self.oclIsKindOf(sysml::AnnotatingElement))"); | ||
| return precondition; | ||
| } | ||
|
|
Bug: #1771 Signed-off-by: Michaël Charfadi <michael.charfadi@obeosoft.com>
AxelRICHARD
force-pushed
the
mch/enh/detail-helpText
branch
from
bc395dc to
6037df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: #1771
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests