Skip to content

Conversation

@MaximilianSoerenPollak
Copy link
Contributor

The pipe into 'tee' has made it so only the exit code of the 'tee' action was recorded / interpreted by github. This meant that any fail inside the consumer test was ignored and it only failed if the 'tee' action would fail.

📌 Description

🚨 Impact Analysis

  • This change does not violate any tool requirements and is covered by existing tool requirements
  • This change does not violate any design decisions
  • Otherwise I have created a ticket for new tool qualification

✅ Checklist

  • Added/updated documentation for new or changed features
  • Added/updated tests to cover the changes
  • Followed project coding standards and guidelines

The pipe into 'tee' has made it so only the exit code of the 'tee'
action was recorded / interpreted by github. This meant that any fail
inside the consumer test was ignored and it only failed if the 'tee'
action would fail.
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 76a8c5e0-e8f1-4042-9a36-db11f26917b5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (68 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (73 packages loaded, 9 targets configured)

Analyzing: target //src:license-check (123 packages loaded, 2293 targets configured)

Analyzing: target //src:license-check (129 packages loaded, 2435 targets configured)

Analyzing: target //src:license-check (135 packages loaded, 2484 targets configured)

INFO: Analyzed target //src:license-check (137 packages loaded, 4500 targets configured).
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 12.761s, Critical Path: 0.39s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

run: |
.venv_docs/bin/python -m pytest -s -v src/tests/ --repo="$CONSUMER" --junitxml="reports/${{ matrix.consumer }}.xml" | tee "reports/${{ matrix.consumer }}.log"
run: "set -o pipefail \n.venv_docs/bin/python -m pytest -s -v src/tests/ --repo=\"$CONSUMER\" --junitxml=\"reports/${{ matrix.consumer }}.xml\" | tee \"reports/${{ matrix.consumer }}.log\"\n#magic___^_^___line\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite get what is going on here. But please make it multiline.
Can you add a comment explaining the magic.

Suggested change
run: "set -o pipefail \n.venv_docs/bin/python -m pytest -s -v src/tests/ --repo=\"$CONSUMER\" --junitxml=\"reports/${{ matrix.consumer }}.xml\" | tee \"reports/${{ matrix.consumer }}.log\"\n#magic___^_^___line\n"
run: |
set -o pipefail
.venv_docs/bin/python -m pytest -s -v src/tests/ --repo="$CONSUMER" --junitxml="reports/${{ matrix.consumer }}.xml" | tee "reports/${{ matrix.consumer }}.log\"\n#magic___^_^___line"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the formatting automation that made it like this q_q.
I change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the formating is so weird here.
I don't know why the bazel run //src:format.fix command insits on this being a single line like:

        run: "set -o pipefail \n.venv_docs/bin/python -m pytest -s -v src/tests/ --repo=\"$CONSUMER\" --junitxml=\"reports/${{ matrix.consumer }}.xml\" | tee \"reports/${{ matrix.consumer }}.log\"\n"

Even when I specify it as a valid multi line like so:

     run: |
          set -o pipefail
          .venv_docs/bin/python -m pytest -s -v src/tests/ --repo="$CONSUMER" --junitxml="reports/${{ matrix.consumer }}.xml" | tee "reports/${{ matrix.consumer }}.log"

Any idea why this is happening?
And I can't pass the formating check if we use the single line.
But as you said i find this much less readable. Is there maybe a setting we can change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm seems that it is fixed.

@AlexanderLanin AlexanderLanin merged commit ef3ff12 into eclipse-score:main Jan 23, 2026
14 checks passed
@github-project-automation github-project-automation bot moved this from Draft to Done in Infrastructure Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants