tracing(interface_types): make headers public and add trace_library_interface to generic_trace_api_header deps#24
Closed
Abdelaziz177 wants to merge 2 commits intoeclipse-score:mainfrom
Conversation
…nterface to generic_trace_api_header deps - visibility: __subpackages__ → //visibility:public - deps: add :trace_library_interface to generic_trace_api_header This unblocks communication/impl/tracing which consumes the interface types directly when building QNX IPC example.
…nterface to generic_trace_api_header deps
Abdelaziz177
requested review from
LittleHuba,
castler,
hoe-jo,
nradakovic and
ramceb
as code owners
hoppe-and-dreams
suggested changes
Nov 25, 2025
| @@ -1,31 +1,42 @@ | |||
| # ******************************************************************************* | |||
| # ****************************************************************************** | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Please don't butcher the license.
| ], | ||
| ) | ||
| visibility = ["//visibility:public"], | ||
| ) No newline at end of file |
Contributor
There was a problem hiding this comment.
Please proper file ending according to POSIX is a new line.
| visibility = [ | ||
| "@score_baselibs//score/analysis/tracing/generic_trace_library:__subpackages__", | ||
| ], | ||
| visibility = ["//visibility:public"], |
Contributor
There was a problem hiding this comment.
Why is this needed now? What changed that makes this necessary?
Member
|
This PR has no activity since a while, I'm closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visibility: switch the following targets to //visibility:public so downstream repos (e.g. communication) can depend on them directly:
generic_trace_api_header
trace_library_interface
meta_info
type_definitions
Dependency fix: add :trace_library_interface to :generic_trace_api_header deps.
generic_trace_api.h includes i_trace_library.h, so this must be provided transitively; otherwise downstream builds see missing headers.
Background / context
While building the QNX IPC example and communication’s tracing code, we hit missing-header and visibility errors because
@score-baselibs//score/analysis/tracing/generic_trace_library/interface_types targets were restricted to subpackages
and generic_trace_api_header didn’t expose the interface include it uses.
communication consumes the interface types directly (not the full tracing lib), so these symbols need to be publicly visible.
Impact
Unblocks communication/score/mw/com/impl/tracing and the QNX IPC example build.
No behavioral changes; build/visibility only.
Notes for reviewers
Only BUILD file changes; no C++ source changes.
The change preserves existing warning features (COMPILER_WARNING_FEATURES).
Testing
Rebuilt locally after the change and verified that communication can depend on the interface targets without visibility or missing-header failures.
Built the QNX IPC example with the updated deps.