Skip to content

Remove Ctrl C accelerator in Copy Variable/Expression#2671

Merged
merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:bugFix
May 25, 2026
Merged

Remove Ctrl C accelerator in Copy Variable/Expression#2671
merks merged 1 commit into
eclipse-platform:masterfrom
SougandhS:bugFix

Conversation

@SougandhS
Copy link
Copy Markdown
Contributor

@SougandhS SougandhS commented May 23, 2026 •
edited
Loading

Removes cmd+c accelerator in Copy Variable & Copy Expression Context of
Expressions View and Variables View

Screenshot 2026-05-23 at 9 21 13 PM

Fixes : #2670

@SougandhS SougandhS mentioned this pull request May 23, 2026
Open
merks
merks reviewed May 23, 2026
View reviewed changes
Comment thread debug/org.eclipse.debug.ui/plugin.xml Outdated
@ewillink
Copy link
Copy Markdown

ewillink commented May 23, 2026

-1

No. The legacy Ctrl-C behaviour was "Copy Variables" which is now "Copy Row".

It is "Copy Variable" that is a new functionality and so must have a new accelerator.

("Copy Row" is a better spelling of "Copy Variables").

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 23, 2026 •
edited
Loading

Test Results

    54 files  ±0      54 suites  ±0   34m 51s ⏱️ - 1m 19s
 4 667 tests ±0   4 645 ✅ ±0   22 💤 ±0  0 ❌ ±0 
11 895 runs  ±0  11 742 ✅ ±0  153 💤 ±0  0 ❌ ±0 

Results for commit 5939433. ± Comparison against base commit 71fc717.

♻️ This comment has been updated with latest results.

@SougandhS SougandhS force-pushed the bugFix branch 2 times, most recently from 9598978 to ac54b67 Compare May 23, 2026 15:26
@SougandhS
Copy link
Copy Markdown
Contributor Author

SougandhS commented May 23, 2026

-1

No. The legacy Ctrl-C behaviour was "Copy Variables" which is now "Copy Row".

It is "Copy Variable" that is a new functionality and so must have a new accelerator.

("Copy Row" is a better spelling of "Copy Variables").

Will add a new shortcut for Copy Variable & Copy Expression context in 4.41 M1. Right now removed the duplicate accelerators

@SougandhS SougandhS changed the title Remove Ctrl C accelerator in Copy Row Remove Ctrl C accelerator in Copy Variable/Expression May 23, 2026
@SougandhS SougandhS requested a review from merks May 23, 2026 16:20
merks
merks reviewed May 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are some pointless overrides.

Comment thread .../eclipse/debug/internal/ui/actions/expressions/CopyVariableRowToClipboardActionDelegate.java Outdated
Comment thread ...clipse/debug/internal/ui/actions/expressions/CopyExpressionRowToClipboardActionDelegate.java Outdated
@SougandhS
Remove Ctrl C accelerator in Copy Variable/Expression
5939433 
Removes cmd+c accelerator in Copy Variable & Copy Expression Context of
Expressions View and Variables View

Fixes : eclipse-platform#2670
@SougandhS
Copy link
Copy Markdown
Contributor Author

SougandhS commented May 25, 2026

I think there are some pointless overrides.

You're right, that overrides was unnecessary. - Removed it 👍

@SougandhS SougandhS requested a review from merks May 25, 2026 01:37
merks
merks approved these changes May 25, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay.

@akurtakov @HannesWell

Who else needs to review and approve this?

@akurtakov
Copy link
Copy Markdown
Member

akurtakov commented May 25, 2026

@merks Please merge if you're fine with it.

@merks merks merged commit 3b9b910 into eclipse-platform:master May 25, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merks merks merks approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression: Confusing Ctrl C in Debug View

4 participants

@SougandhS @ewillink @akurtakov @merks