Modernize ResourceChangeEvent.findMarkerDeltas iteration#2666
Draft
vogella wants to merge 1 commit into
Draft
Conversation
Replace the explicit Iterator over markerDeltas.values() with an enhanced for-loop and switch the terminal toArray call from the pre-sized new IMarkerDelta[matching.size()] form to the IMarkerDelta[]::new generator. The pre-sized form has not been the faster idiom on HotSpot since the size-zero/generator variants started being intrinsified, and the enhanced for-loop drops the hasNext/next boilerplate while reading the iteration intent in one statement.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the explicit
IteratorovermarkerDeltas.values()with an enhanced for-loop and swaps the terminaltoArray(new IMarkerDelta[matching.size()])fortoArray(IMarkerDelta[]::new). The pre-sized array form stopped being the faster idiom once HotSpot started intrinsifying the size-zero/generator variants, and the enhanced for-loop removes thehasNext/nextboilerplate. Behaviour is unchanged.Planned for 4.41