Make waitWhile() utility method in debug tests static #2388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The waitWhile() method for waiting until a condition is fulfilled is implemented as an instance method of AbstractDebugTest. The reason is that the test class instance itself is passed as a context to that method. This context, however, is not used by any of the method's consumers. This change removes the unnecessary context from the waitWhile() method and simplifies all consumers accordingly. With that, the method in AbstractDebugTests degrades to a pure delegation to the same method in TestUtil, which is why the method is removed from the test superclass and consumers are adapted to directly call the method in TestUtil.
HeikoKlare
force-pushed
the
junit5-debugtests-waitwhile
branch
from
81f45c1 to
1817570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waitWhile() method for waiting until a condition is fulfilled is implemented as an instance method of AbstractDebugTest. The reason is that the test class instance itself is passed as a context to that method. This context, however, is not used by any of the method's consumers.
This change removes the unnecessary context from the waitWhile() method and simplifies all consumers accordingly. With that, the method in AbstractDebugTests degrades to a pure delegation to the same method in TestUtil, which is why the method is removed from the test superclass and consumers are adapted to directly call the method in TestUtil.