Streamline debug tests timeout handling #2387
Merged
+58
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug tests use a centrally defined timeout when waiting for some condition. This value is defined in a non-final way in a superclass instead of the central TestUtil to where it is passed by most consumers. This moves the default timeout value to the TestUtil class and adds a convenience version of the the waitWhile() method that uses this timeout value, as it is passed by most consumers anyway.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug tests use a centrally defined timeout when waiting for some condition. This value is defined in a non-final way in a superclass instead of the central TestUtil to where it is passed by most consumers.
This moves the default timeout value to the TestUtil class and adds a convenience version of the the waitWhile() method that uses this timeout value, as it is passed by most consumers anyway.