Replace Hamcrest matcher in resource tests with AssertJ assertion #2382
+36
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamcrest is available by default when using JUnit 4. With JUnit 5, Hamcrest has to be required as an additional dependency. At the same time, we already have a dependency to the more up-to-date AssertJ library. For that reason, this change adapts the last remaining Hamcrest usage in resource tests, a matcher for marker severities, with an equivalent assertion based on AssertJ.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hamcrest is available by default when using JUnit 4. With JUnit 5, Hamcrest has to be required as an additional dependency. At the same time, we already have a dependency to the more up-to-date AssertJ library. For that reason, this change adapts the last remaining Hamcrest usage in resource tests, a matcher for marker severities, with an equivalent assertion based on AssertJ.