Remove inheritance hierarchy from Ant UI performance tests #2353
+351
−360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ant UI tests use an inheritance hierarchy for sharing configuration and utility methods. This leads to duplications of performance test functionality and unnecessary classes for sharing utilities. This change removes the AbstractAntUIBuildPerformanceTest and AbstractAntPerformanceTest classes by reusing the PerformanceTestCaseJunit5 and integrating the remaining functionality into the single concrete performance test classes. In order to allow reuse of several inherited utility methods, they are moved to a dedicated AntUITestUtil class. In addition, the functionality for closing the welcome screen, which is embedded into the setup functionality of the common Ant UI test superclass, is extracted into a JUnit 5 extension to be used throughout all tests upon JUnit 5 migration.
HeikoKlare
force-pushed
the
ant-ui-performancetests-inheritance
branch
from
eacde6a to
6904f06
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ant UI tests use an inheritance hierarchy for sharing configuration and utility methods. This leads to duplications of performance test functionality and unnecessary classes for sharing utilities.
This change removes the
AbstractAntUIBuildPerformanceTestandAbstractAntPerformanceTestclasses by reusing thePerformanceTestCaseJunit5and integrating the remaining functionality into the single concrete performance test classes. In order to allow reuse of several inherited utility methods, they are moved to a dedicated AntUITestUtil class. In addition, the functionality for closing the welcome screen, which is embedded into the setup functionality of the common Ant UI test superclass, is extracted into a JUnit 5 extension to be used throughout all tests upon JUnit 5 migration.