Remove JUnit 3 compatibility from PerformanceTestRunner #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PerformanceTestRunner used to have different methods for executing performance tests. One of them accepts JUnit 3's TestCase. All consumers of that method have been replaced, such that the method can be removed. This also leads to unused parameters in internal methods that are removed by this change as well. Contributes to eclipse-platform#903
HeikoKlare
force-pushed
the
PerformanceTestRunner-remove-junit3
branch
from
86de33b to
e763b0b
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PerformanceTestRunner used to have different methods for executing performance tests. One of them accepts JUnit 3's TestCase. All consumers of that method have been replaced, such that the method can be removed. This also leads to unused parameters in internal methods that are removed by this change as well.
The last remaining consumers in Equinox and p2 have just been replaced:
Contributes to #903