Replace custom AssertionFailedErrors in test harness based on org.junit #2348
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
The custom AssertionFailedErrors specified in org.eclipse.core.tests.harness are derived from JUnit 3/4's AssertionFailedError coming from org.junit. In order to fully migrate the test harness to JUnit 5, this change adapts those classes to subclass the AssertionFailedError from org.opentest4j as done by JUnit 5 as well. Contributes to eclipse-platform#903
HeikoKlare
force-pushed
the
assertionfailederror-tests.harness
branch
from
d8ecf0f to
68d2734
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom
AssertionFailedErrorsspecified inorg.eclipse.core.tests.harnessare derived from JUnit 3/4'sAssertionFailedErrorcoming from org.junit. In order to fully migrate the test harness to JUnit 5, this change adapts those classes to subclass the AssertionFailedError from org.opentest4j as done by JUnit 5 as well.Contributes to #903
Requires #2350