Skip to content

Fix selection not updating when checking a tree item on Import window #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanvtdeptre199 wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −0
Open

Fix selection not updating when checking a tree item on Import window #4084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e8602f
Fix selection not updating when checking a tree item on Windows
tuanvtdeptre199 Jun 11, 2026
559f16a
Fix 1
tuanvtdeptre199 Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/dialogs/ResourceTreeAndListGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
import java.util.Objects;
import java.util.Set;

import org.eclipse.core.commands.common.EventManager;
Expand Down Expand Up @@ -73,6 +74,15 @@ public void checkStateChanged(final CheckStateChangedEvent event) {
BusyIndicator.showWhile(treeViewer.getControl().getDisplay(),
() -> {
if (event.getCheckable().equals(treeViewer)) {
/*
* On Windows, checking an item does not automatically update the tree selection
* like on Linux environment. Force the checked element to become the current
* selection so SelectionListener and CheckListener stay in sync together
*/
Object currentSelection = treeViewer.getStructuredSelection().getFirstElement();
if (!Objects.equals(currentSelection, event.getElement())) {
treeViewer.setSelection(new StructuredSelection(event.getElement()), true);
}
treeItemChecked(event.getElement(), event
.getChecked());
} else {
Expand Down