Trace quick access table disposal#4083
Draft
trancexpress wants to merge 2 commits into
Draft
Conversation
Contributor
Test Results 861 files ± 0 861 suites ±0 45m 40s ⏱️ - 12m 28s For more details on these failures, see this check. Results for commit 23fb09d. ± Comparison against base commit 968d4ce. ♻️ This comment has been updated with latest results. |
trancexpress
force-pushed
the
gh4009
branch
3 times, most recently
from
9844577 to
07adab6
Compare
Contributor
Author
|
The tests in Unfortunately the new tracing is hard to use, without knowing which test is running (still no clue where the workspace logs are for GH jobs)... |
trancexpress
force-pushed
the
gh4009
branch
2 times, most recently
from
6fb2161 to
b57c207
Compare
Tracing for fail in QuickAccessDialogTest hints at a disposed table prior to updating entries in the table. This change adds tracing for table dispose to validate this. See: eclipse-platform#4009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracing for fail in
QuickAccessDialogTesthints at a disposed table prior to updating entries in the table. This change adds tracing for table dispose to validate this.See: #4009