Fix Windows Defender status retrieval under Java-25 or later#3994
Open
HannesWell wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Fix Windows Defender status retrieval under Java-25 or later#3994HannesWell wants to merge 1 commit intoeclipse-platform:masterfrom
HannesWell wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Fixes errors like: ''' Failed to obtain 'WinDefend' service state java.io.IOException: Process timed-out and it was attempted to forcefully terminate it '''
82e6506 to
ac4d0af
Compare
merks
approved these changes
May 10, 2026
Contributor
merks
left a comment
There was a problem hiding this comment.
It's not so easy to test without a build, I see zero risk in this producing worse behavior given If the process has already terminated then this method returns immediately with the value {@code true}. So it should exactly deal with the case of it taking a while for isAlive to return false, and in the worst case taking 5 second longer to pop up a failure message...
Contributor
Contributor
|
If we merge this today, I can more easily test tomorrow's I-build... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In recent Java versions
Process.isAlive()seems to report the termination of a process a little bit later then before leading to false errors about process time-out.Fixes errors like:
I cannot yet tell why, because I haven’t investigated the details yet.
CC @merks and @azoitl
Does this also help for