Skip to content

Remove redundant isCanceled checks in SaveablesList and SaveableHelper #3578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptziegler merged 1 commit into from
Dec 14, 2025
+0 −6
Merged

Remove redundant isCanceled checks in SaveablesList and SaveableHelper #3578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveableHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,9 +193,6 @@ private static boolean saveModels(ISaveablesSource modelSource, final IWorkbench
continue;
}
doSaveModel(model, subMonitor.split(1), window, confirm);
if (subMonitor.isCanceled()) {
break;
}
}
} finally {
monitorWrap.done();
Expand Down
3 changes: 0 additions & 3 deletions bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/SaveablesList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,9 +796,6 @@ public boolean saveModels(final List<Saveable> finalModels, final IShellProvider
continue;
}
SaveableHelper.doSaveModel(model, subMonitor.split(1), shellProvider, blockUntilSaved);
if (subMonitor.isCanceled()) {
break;
}
}
monitorWrap.done();
};
Expand Down
Loading