[Gtk4] Fix PaintListener paint ordering for all widget types#3308
Merged
Conversation
On Gtk 4, PaintListener on leaf controls (Button, Label, etc.) drew custom content under the native widget appearance instead of over it (issue eclipse-platform#2819). Fixing this by simply moving snapshotToDraw after the children loop regressed JFace Forms rendering (PR eclipse-platform#3299). New paint-ordering scheme that mirrors Gtk 3's signal split (EXPOSE_EVENT_INVERSE for containers, DRAW/EXPOSE_EVENT for leaf controls).
Member
Author
|
Fixes #2819 |
Contributor
jonahgraham
approved these changes
May 15, 2026
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
This change fixes the top comment case in #2819, but #2819 (comment) shows that we are calling paint listener twice still on GTK4 even with this change.
Snippet for the above is the one from #2819 (comment) but I changed the color to red to make it easier to see.
I am approving this as it does move forward, but I am not going to let it close the issue until we discuss further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Gtk 4, PaintListener on leaf controls (Button, Label, etc.) drew custom content under the native widget appearance instead of over it (issue #2819). Fixing this by simply moving snapshotToDraw after the children loop regressed JFace Forms rendering (PR #3299).
New paint-ordering scheme that mirrors Gtk 3's
signal split (EXPOSE_EVENT_INVERSE for containers, DRAW/EXPOSE_EVENT for leaf controls).