Improve stability of Text cut/copy/paste tests on Windows#3081
Open
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Improve stability of Text cut/copy/paste tests on Windows#3081HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
The tests for cut/copy/paste functionality of Text widgets in Test_org_eclipse_swt_widgets_Text sporadically fail on Windows. Locally, they fail on almost every execution. This seems to either be caused by some timing issue at the OS or by the need to spin the event queue for processing the cut/copy/paste operations at the OS. In some tests, according event processing for spinning the event loop and waiting for events have been implemented already for GTK. This change adapts all calls to text.cut()/copy()/paste() such that the event queue is spinned. Fixes eclipse-platform#106 Fixes eclipse-platform#876
Contributor
Contributor
Author
|
@jonahgraham you have been working on the Clipboard and according tests quite heavily. What do think about this adaptation of the tests? Do you see any risk? It significantly improves (or even fix) the test behavior on Windows for me, but I would like to avoid that it, e.g., breaks something for GTK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests for cut/copy/paste functionality of Text widgets in Test_org_eclipse_swt_widgets_Text sporadically fail on Windows. Locally, they fail on almost every execution (for me). This seems to either be caused by some timing issue at the OS or by the need to spin the event queue for processing the cut/copy/paste operations at the OS.
In some tests, according event processing for spinning the event loop and waiting for events have been implemented already for GTK. This change adapts all calls to text.cut()/copy()/paste() such that the event queue is spinned. For me, it fixes all local test failures of that test class.
This fix attempt was triggered by the according tests spordically but frequently failing in I-Build test execution, such as:
https://download.eclipse.org/eclipse/downloads/drops4/I20260213-1800/testresults/html/org.eclipse.swt.tests_ep439I-unit-win32-x86_64-java21_win32.win32.x86_64_21.html
Fixes #106
Fixes #876