[Win32] Update JavaDoc in GC.setXORMode() regarding limitation with GDI+#3006
Open
ptziegler wants to merge 1 commit intoeclipse-platform:masterfrom
Open
[Win32] Update JavaDoc in GC.setXORMode() regarding limitation with GDI+#3006ptziegler wants to merge 1 commit intoeclipse-platform:masterfrom
ptziegler wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Enabling advanced mode causes SWT to switch from GDI to the GDI+. With GDI+, certain features, such as XOR, are not supported. This limitation should be documented. Closes eclipse-platform#2984
Contributor
HeikoKlare
reviewed
Jan 24, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
Thank you for adding this explanation to the Javadoc. It makes sense to have this limited functionality documented.
| * puts the receiver in a drawing mode where the destination color | ||
| * is replaced with the source color value. | ||
| * <p> | ||
| * <b>IMPORTANT:</b> GDI+ has no direct support for raster |
Contributor
There was a problem hiding this comment.
The Javadoc of SWT API needs to be the same for every OS (as it is or at least can be consumed in an OS-agnostic way). So this extension needs to be applied to the GTK and Cocoa implementations of GC as well.
To make such a comment reasonable in an OS-agnostic way, it should start with an according statement, such as: "This operation may not work on every platform. Especially on Windows, GDI+ has no direct support [...]".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling advanced mode causes SWT to switch from GDI to the GDI+. With GDI+, certain features, such as XOR, are not supported. This limitation should be documented.
Closes #2984