-
Notifications
You must be signed in to change notification settings - Fork 191
Prepare 4.39 development #2829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 4.39 development #2829
Conversation
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Test Results 118 files ±0 118 suites ±0 14m 34s ⏱️ - 1m 41s Results for commit 6cc448c. ± Comparison against base commit a0d6ffc. This pull request skips 1 test.♻️ This comment has been updated with latest results. |
|
I don't understand why there are API errors: All these methods are still there. |
|
@laeubi : I remember you were working in this area in tycho/PDE recently, to get some API data differently. Could that be related? SWT was always "special", with fragments etc. |
|
It seems like it's exactly those methods that have been added in the current release. It seems like for the preexisting methods, we have added according API filters at the beginning of the previous release cycle: 44d4a11 |
When reproducing the issue locally it seems like extending the list helps. I'm working on it, but it might take a few minutes and I don't know if I have time to complete it today. |
I just started to try them same. The filters look the same for every fragment, so it should be easy to copy over, shouldn't it? |
Yes, just started to apply them partially to see if this works. Try to complete it later. |
|
It seems to work with the filters you added. When I added the same method filters locally, I still got this: It's because of the |
01f780e to
6cc448c
Compare
|
Thanks for testing. The build looks good. Only Jenkins hang and I restarted it for one more attempt.
I believe this is eclipse-pde/eclipse.pde#1496 (we always have the same problems each time a new stream is opened 😅) |
|
All github workflows pass, so the filter seem to be working now. |
Add filters for the new methods added in the previous release cycle. Similar to - #2467 (comment)
6cc448c to
0ad281f
Compare
Prepare development of Eclipse 4.39.
This complements: