Skip to content

Clean Code for ui/org.eclipse.pde.junit.runtime.tests#2193

Open
eclipse-pde-bot wants to merge 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.junit.runtime.tests
Open

Clean Code for ui/org.eclipse.pde.junit.runtime.tests#2193
eclipse-pde-bot wants to merge 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.junit.runtime.tests

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Test Results

   519 files  ± 0     519 suites  ±0   56m 31s ⏱️ - 2m 9s
 3 597 tests  -  5   3 459 ✅  -  89   54 💤 ±0  56 ❌ +56  28 🔥 +28 
11 112 runs   - 15  10 825 ✅  - 139  163 💤 ±0  40 ❌ +40  84 🔥 +84 

For more details on these failures and errors, see this check.

Results for commit 824f8ef. ± Comparison against base commit 38e5986.

This pull request removes 6 and adds 1 tests. Note that renamed tests count towards both.
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executePackage[JUnit5]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executePackage[JUnit6]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executeProject[JUnit5]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executeProject[JUnit6]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executeSuite[JUnit5]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ executeSuite[JUnit6]
JUnitRuntimeTests org.eclipse.pde.junit.runtime.tests.JUnitSuiteExecutionTest ‑ Unknown test

♻️ This comment has been updated with latest results.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.junit.runtime.tests branch from 41592bc to 29d1530 Compare March 2, 2026 03:58
@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 2, 2026

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
ui/org.eclipse.pde.junit.runtime.tests/pom.xml

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 7df9e1f5d68b6e01ecee23c7e98c5f4b39a0d5fa Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Fri, 6 Mar 2026 04:11:36 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
index 683f05880c..28a86acd6c 100644
--- a/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.junit.runtime.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: PDE JUnit Runtime Tests
 Bundle-SymbolicName: org.eclipse.pde.junit.runtime.tests;singleton:=true
-Bundle-Version: 3.8.300.qualifier
+Bundle-Version: 3.8.400.qualifier
 Automatic-Module-Name: org.eclipse.pde.junit.runtime.tests
 Bundle-RequiredExecutionEnvironment: JavaSE-21
 Bundle-Vendor: Eclipse.org
diff --git a/ui/org.eclipse.pde.junit.runtime.tests/pom.xml b/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
index 44b02f7795..ebfaac30ee 100644
--- a/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
+++ b/ui/org.eclipse.pde.junit.runtime.tests/pom.xml
@@ -24,7 +24,7 @@
 		<relativePath>../../</relativePath>
 	</parent>
 	<artifactId>org.eclipse.pde.junit.runtime.tests</artifactId>
-	<version>3.8.300-SNAPSHOT</version>
+	<version>3.8.400-SNAPSHOT</version>
 	<packaging>eclipse-test-plugin</packaging>
 	<build>
 		<plugins>
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.junit.runtime.tests branch from 806a842 to 81a6bab Compare March 6, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant