Skip to content

Clean Code for ui/org.eclipse.pde.bnd.ui#2191

Open
eclipse-pde-bot wants to merge 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.bnd.ui
Open

Clean Code for ui/org.eclipse.pde.bnd.ui#2191
eclipse-pde-bot wants to merge 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.bnd.ui

Conversation

@eclipse-pde-bot
Copy link
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@eclipse-pde-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From dd6102b5121fa0e79a837f340497bc3592116b51 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Tue, 20 Jan 2026 14:28:58 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
index c97edb2fd9..af6778525c 100644
--- a/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.bnd.ui/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Bundle-ManifestVersion: 2
 Bundle-Name: Generic UI components related to BND
 Bundle-SymbolicName: org.eclipse.pde.bnd.ui;singleton:=true
 Bundle-Vendor: Eclipse.org
-Bundle-Version: 1.2.400.qualifier
+Bundle-Version: 1.2.500.qualifier
 Bundle-Localization: plugin
 Export-Package: org.eclipse.pde.bnd.ui.autocomplete;version="1.0.0";x-friends:="org.eclipse.pde.ui",
  org.eclipse.pde.bnd.ui.plugins;x-internal:=true,
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link

Test Results

   798 files  ±0     798 suites  ±0   1h 0m 35s ⏱️ -40s
 3 732 tests ±0   3 596 ✅ +1  136 💤 ±0  0 ❌  - 1 
11 127 runs  ±0  10 718 ✅ +1  409 💤 ±0  0 ❌  - 1 

Results for commit ce3759c. ± Comparison against base commit 1e53ff5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant