feat: Inlay hints with text edits can be applied when clicking on them#1505
Draft
FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Draft
feat: Inlay hints with text edits can be applied when clicking on them#1505FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
FlorianKroiss wants to merge 1 commit intoeclipse-lsp4e:mainfrom
Conversation
Contributor
Author
|
Labelled as draft, because I'm not entirely happy with it. I'm not sure if the LSP defines whether a command or the text edits takes precedence, when the user clicks on the inlay hint. I also think that accepting the inlay hint with a single click makes it easy to trigger by accident.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlay hints can have text-edits, which VS Code applies when double clicking on them. We already had support for executing commands when clicking on individual parts of the inlay hint. With this PR, we additionally check if there are text-edits and apply them, when the user clicks on it.
It looks like this in action:
https://github.com/user-attachments/assets/aa7bd610-e727-40bf-b326-b8ca468552c0
In the above example, the LS inferred the type of the right hand side expression and the user can accept the inferred type.