GLSP-1067: Ensure proper bundling of workflow editor example #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update maven build to temporarily remove the .gitignore file for diagram resourced during build. This ensures that tycho properly includes the resources in the workflow editor plugin for the p2 update site. Also fix broken codeql workflow Fixes eclipse-glsp/glsp/issues/1067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Update maven build to temporarily remove the .gitignore file for diagram resourced during build. This ensures that tycho properly includes the resources in the workflow editor plugin for the p2 update site.
Also fix broken codeql workflow
Fixes eclipse-glsp/glsp/issues/1067
How to test
Inspect nightly p2 site after merge. It should now include the diagram resources
Follow-ups
Changelog