feat: enable IPv6 support for factory resolver endpoints by olexii4 · Pull Request #951 · eclipse-che/che-server

olexii4 · 2026-02-02T14:35:32Z

What does this PR do?

This change adds IPv6 support in Eclipse Che Server to enable operation in IPv6-only network environments. As Kubernetes platforms (particularly OpenShift Container Platform 4.20) migrate to IPv6, the factory resolver must handle IPv6 addresses correctly in URLs and API calls.

The implementation involved minimal, focused changes to URL validation patterns and server URL extraction, enabling full IPv6 support while maintaining complete backward compatibility with IPv4-only and dual-stack environments.

Background:

The Eclipse Che factory resolver previously failed to operate with IPv6 git server URLs due to:

URL Validation Issues: Regular expressions rejected IPv6 bracket notation (e.g., http://[::1]:8080)
Manual String Parsing: getServerUrl() methods used pattern matching that didn't account for IPv6 brackets
Regex Escaping: Host strings from IPv6 URLs were inserted into regex patterns without properly escaping the bracket characters

IPv6 Bracket Notation:

IPv6 addresses in URLs require square brackets to distinguish the address from port numbers:

✅ Correct: http://[2001:db8::1]:8080/repo.git
❌ Incorrect: http://2001:db8::1:8080/repo.git (ambiguous)

Changes:

AbstractGitlabUrlParser:
- Fixed constructor to use URI.getHost() instead of manual substring extraction
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support
AbstractGithubURLParser:
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support
AzureDevOpsURLParser:
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support

Technical Details:

Java's URI.getHost() returns IPv6 addresses WITH brackets (e.g., "[2001:db8::1]"). When constructing regex patterns, these brackets must be escaped as \[ and \] because they are special regex characters. The fix uses:

Pattern.quote() to escape the IPv6 address (without brackets)
Manual escaping of the brackets themselves

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes: eclipse-che/che#23674

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci · 2026-02-02T14:35:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

olexii4 · 2026-02-05T14:41:13Z

/retest

...-common/src/main/java/org/eclipse/che/api/factory/server/gitlab/AbstractGitlabUrlParser.java

...vops/src/main/java/org/eclipse/che/api/factory/server/azure/devops/AzureDevOpsURLParser.java

vinokurig · 2026-02-06T08:27:44Z

@olexii4 Please update the related tests with ip v6 examples.

...est/java/org/eclipse/che/api/core/util/lineconsumer/ConcurrentCompositeLineConsumerTest.java

...infrastructure/kubernetes/docker/auth/UserSpecificDockerRegistryCredentialsProviderTest.java

olexii4 · 2026-02-09T11:55:24Z

...pace/infrastructure/kubernetes/namespace/configurator/CredentialsSecretConfiguratorTest.java

-    KubernetesClient client = spy(kubernetesClient);
-    when(cheServerKubernetesClientFactory.create()).thenReturn(client);
+    kubernetesClient = kubernetesMockServer.createClient();
+    when(cheServerKubernetesClientFactory.create()).thenReturn(kubernetesClient);


These changes were required because Mockito 5 doesn't allow spy() on mock objects. This is a breaking change from Mockito 3.x:

Changes made:

Removed import static org.mockito.Mockito.spy;

Changed setup from:

kubernetesClient = spy(kubernetesMockServer.createClient()); KubernetesClient client = spy(kubernetesClient); when(cheServerKubernetesClientFactory.create()).thenReturn(client);

To:

kubernetesClient = kubernetesMockServer.createClient(); when(cheServerKubernetesClientFactory.create()).thenReturn(kubernetesClient);

olexii4 · 2026-02-09T11:59:05Z

...c/test/java/org/eclipse/che/multiuser/permission/system/JvmServicePermissionsFilterTest.java

            })
        .when(subject)
-        .checkPermission(anyObject(), anyObject(), anyObject());
+        .checkPermission(any(), any(), any());


This change was required for Mockito 5 compatibility due to the removal of the deprecated anyObject() matcher:

Change made:

Import: ArgumentMatchers.anyObject() → ArgumentMatchers.any()

Usage: checkPermission(anyObject(), anyObject(), anyObject()) → checkPermission(any(), any(), any())

...ver/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketServerURLParser.java

Fix IPv6 bracket handling and SSH URL parsing issues: - GitLab: Fix double-bracketing bug in getPatternMatcherByUrl() where IPv6 addresses were wrapped in additional brackets - GitHub: Add sshToUri() helper to correctly handle IPv6 addresses in SSH URLs - GitLab: Add sshToUri() helper to correctly handle IPv6 addresses in SSH URLs - Azure DevOps: Fix SSH URL parsing to handle IPv6 bracket notation Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Oleksii Orel <oorel@redhat.com>

Add complete IPv6 address support to BitbucketServerURLParser: - Add IPv6 bracket handling in getUrlPatterns(), isUserTokenPresent(), and getPatternMatcherByUrl() - Fix SSH URL parsing to correctly handle IPv6 addresses with bracket notation - Escape scheme parameter in regex patterns to prevent regular expression injection (fixes CodeQL security warnings) Security: Use Pattern.quote() on user-controlled scheme values before inserting into regex patterns to prevent regex injection attacks. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Oleksii Orel <oorel@redhat.com>

Add 39 new IPv6 test cases across all parsers (from 4 to 43 total): - Azure DevOps: 8 new IPv6 tests covering branches, tags, loopback, credentials, dynamic pattern matching - GitHub: 8 new IPv6 tests covering branches, pull requests, dynamic patterns, loopback, .git suffix - GitLab: 11 new IPv6 tests covering subgroups, validation, branches with slashes, loopback - Bitbucket Server: 12 new IPv6 tests (from zero coverage) covering HTTPS, SSH, user repos, branches, validation Test scenarios include: - IPv6 with branches and tags - IPv6 with pull request IDs - IPv6 loopback addresses (::1) - IPv6 full-form addresses - IPv6 with ports - IPv6 with credentials - IPv6 SSH URLs - IPv6 URL validation via isValid() - Dynamic pattern matching for unconfigured hosts Also update license headers to 2026 in affected test files. All 238 tests passing across all parsers. Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 · 2026-02-17T14:29:34Z

@olexii4 Please update the related tests with ip v6 examples.

@vinokurig I have fixed it

olexii4 · 2026-02-17T14:29:50Z

/retest

olexii4 · 2026-02-17T22:28:20Z

/retest

openshift-ci · 2026-02-17T22:55:47Z

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v19-gitlab-no-pat-oauth-flow	`28193cb`	link	true	`/test v19-gitlab-no-pat-oauth-flow`
ci/prow/v19-azure-no-pat-oauth-flow-raw-devfile-url	`28193cb`	link	true	`/test v19-azure-no-pat-oauth-flow-raw-devfile-url`
ci/prow/v19-bitbucket-no-pat-oauth-flow	`28193cb`	link	true	`/test v19-bitbucket-no-pat-oauth-flow`
ci/prow/v19-bitbucket-no-pat-oauth-flow-ssh-url	`28193cb`	link	true	`/test v19-bitbucket-no-pat-oauth-flow-ssh-url`
ci/prow/v19-gitea-with-pat-setup-flow	`28193cb`	link	true	`/test v19-gitea-with-pat-setup-flow`
ci/prow/v19-gitlab-with-oauth-setup-flow	`28193cb`	link	true	`/test v19-gitlab-with-oauth-setup-flow`
ci/prow/v19-gitlab-with-pat-setup-flow	`28193cb`	link	true	`/test v19-gitlab-with-pat-setup-flow`
ci/prow/v19-azure-no-pat-oauth-flow-ssh-url	`28193cb`	link	true	`/test v19-azure-no-pat-oauth-flow-ssh-url`
ci/prow/v19-gitea-no-pat-oauth-flow	`28193cb`	link	true	`/test v19-gitea-no-pat-oauth-flow`
ci/prow/v19-github-no-pat-oauth-flow-ssh-url	`28193cb`	link	true	`/test v19-github-no-pat-oauth-flow-ssh-url`
ci/prow/v19-gitlab-no-pat-oauth-flow-ssh-url	`28193cb`	link	true	`/test v19-gitlab-no-pat-oauth-flow-ssh-url`
ci/prow/v19-github-with-pat-setup-flow	`28193cb`	link	true	`/test v19-github-with-pat-setup-flow`
ci/prow/v19-github-no-pat-oauth-flow	`28193cb`	link	true	`/test v19-github-no-pat-oauth-flow`
ci/prow/v19-bitbucket-no-pat-oauth-flow-raw-devfile-url	`28193cb`	link	true	`/test v19-bitbucket-no-pat-oauth-flow-raw-devfile-url`
ci/prow/v19-gitlab-no-pat-oauth-flow-raw-devfile-url	`28193cb`	link	true	`/test v19-gitlab-no-pat-oauth-flow-raw-devfile-url`
ci/prow/v19-github-no-pat-oauth-flow-raw-devfile-url	`28193cb`	link	true	`/test v19-github-no-pat-oauth-flow-raw-devfile-url`
ci/prow/v19-azure-no-pat-oauth-flow	`28193cb`	link	true	`/test v19-azure-no-pat-oauth-flow`
ci/prow/v19-azure-with-pat-setup-flow	`28193cb`	link	true	`/test v19-azure-with-pat-setup-flow`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

olexii4 requested review from SDawley, ibuziuk, tolusha and vinokurig as code owners February 2, 2026 14:35

olexii4 removed the request for review from vinokurig February 2, 2026 14:35

olexii4 force-pushed the CHE-1442 branch from aca921f to 1c59dc9 Compare February 5, 2026 14:55

vinokurig reviewed Feb 6, 2026

View reviewed changes

...-common/src/main/java/org/eclipse/che/api/factory/server/gitlab/AbstractGitlabUrlParser.java Outdated Show resolved Hide resolved

vinokurig reviewed Feb 6, 2026

View reviewed changes

...vops/src/main/java/org/eclipse/che/api/factory/server/azure/devops/AzureDevOpsURLParser.java Outdated Show resolved Hide resolved

vinokurig reviewed Feb 6, 2026

View reviewed changes

...vops/src/main/java/org/eclipse/che/api/factory/server/azure/devops/AzureDevOpsURLParser.java Outdated Show resolved Hide resolved

olexii4 force-pushed the CHE-1442 branch 4 times, most recently from 31df750 to 164262d Compare February 9, 2026 11:22

olexii4 commented Feb 9, 2026

View reviewed changes

...est/java/org/eclipse/che/api/core/util/lineconsumer/ConcurrentCompositeLineConsumerTest.java Outdated Show resolved Hide resolved

olexii4 commented Feb 9, 2026

View reviewed changes

...infrastructure/kubernetes/docker/auth/UserSpecificDockerRegistryCredentialsProviderTest.java Outdated Show resolved Hide resolved

olexii4 commented Feb 9, 2026

View reviewed changes

olexii4 force-pushed the CHE-1442 branch 6 times, most recently from d93322a to 05ab89c Compare February 12, 2026 10:01

github-advanced-security bot found potential problems Feb 13, 2026

View reviewed changes

...ver/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketServerURLParser.java Fixed Show fixed Hide fixed

...ver/src/main/java/org/eclipse/che/api/factory/server/bitbucket/BitbucketServerURLParser.java Fixed Show fixed Hide fixed

olexii4 force-pushed the CHE-1442 branch 3 times, most recently from b556135 to aee02e0 Compare February 17, 2026 01:28

olexii4 added 3 commits February 17, 2026 03:38

olexii4 force-pushed the CHE-1442 branch from aee02e0 to 28193cb Compare February 17, 2026 01:39

olexii4 force-pushed the CHE-1442 branch from ab34320 to 28193cb Compare February 17, 2026 18:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable IPv6 support for factory resolver endpoints#951

feat: enable IPv6 support for factory resolver endpoints#951
olexii4 wants to merge 3 commits intomainfrom
CHE-1442

olexii4 commented Feb 2, 2026 •

edited

Loading

Uh oh!

openshift-ci bot commented Feb 2, 2026

Uh oh!

olexii4 commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinokurig commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

olexii4 Feb 9, 2026

Uh oh!

olexii4 Feb 9, 2026

Uh oh!

Uh oh!

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

openshift-ci bot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

olexii4 commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Background:

IPv6 Bracket Notation:

Changes:

Technical Details:

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Release Notes

Reviewers

Uh oh!

openshift-ci bot commented Feb 2, 2026

Uh oh!

olexii4 commented Feb 5, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vinokurig commented Feb 6, 2026

Uh oh!

Uh oh!

Uh oh!

olexii4 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

olexii4 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

olexii4 commented Feb 17, 2026

Uh oh!

openshift-ci bot commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olexii4 commented Feb 2, 2026 •

edited

Loading