Skip to content

Conversation

@rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Sep 4, 2025

Only additional changes I've made that weren't there, are the addition of iconData & iconMediaType properties.

Copy link
Member

@azatsarynnyy azatsarynnyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the editor definition from the gist, in che-incubator/che-code#560 (review)

@rgrunber
Copy link
Contributor Author

I've done my testing and I'm pretty satisfied with merging this soon. The only thing to figure out is my comment on che-incubator/che-code#560 (comment) . Getting the default resource values into a reasonable range.

@rgrunber
Copy link
Contributor Author

@azatsarynnyy , I don't have anything else to do here for now, so feel free to merge at earliest convenience.

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@ibuziuk
Copy link
Member

ibuziuk commented Sep 25, 2025

@tolusha could you please review & merge?

@openshift-ci
Copy link

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: azatsarynnyy, ibuziuk, rgrunber, tolusha

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha tolusha merged commit 7d98e74 into eclipse-che:main Sep 25, 2025
18 checks passed
@rgrunber rgrunber deleted the sshd branch September 26, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants