This repository was archived by the owner on Feb 2, 2022. It is now read-only.
Fix issue #218.#221
Open
monaka wants to merge 1 commit intoeclipse-che:masterfrom
Open
Conversation
It should not add GAE related files into `eclipse/php` image. Use `eclipse/php:gae` instead. Signed-off-by: Masaki Muranaka <monaka@monami-ya.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should not add GAE related files into
eclipse/phpimage.Use
eclipse/php:gaeinstead.What does this PR do?
Fix issue #218.
What issues does this PR fix or reference?
Previous behavior
The image
eclipse/phpcontains GAE related files.New behavior
Removed GAE related files from the image
eclipse/php.Updated GAE related files in the image
eclipse/php:gae.Tests written?
No
Docs updated?
No