Skip to content

[#24349] Add partition rules to security permissions tests and temporarily patch CMake version to 3.20#537

Merged
Danipiza merged 3 commits intomainfrom
tempfix/dockertest
Apr 15, 2026
Merged

[#24349] Add partition rules to security permissions tests and temporarily patch CMake version to 3.20#537
Danipiza merged 3 commits intomainfrom
tempfix/dockertest

Conversation

@Danipiza
Copy link
Copy Markdown
Contributor

@Danipiza Danipiza commented Apr 14, 2026

Description

This PR updates the DDS Security permission files used by compose security tests to include partition rules.

  • partition not found in rule (Fast DDS AccessControl)
  • subscriber validator timeouts
2026-04-14T12:52:02.9731854Z 19: ddsrouter | �[37;1m2026-04-14 12:52:02.971 
�[31;1m[�[37;1mSECURITY�[31;1m Error] �[37m* partition not found in rule. 
(/ddsrouter/src/fastdds/src/cpp/security/accesscontrol/Permissions.cpp:245)
�[34;1m -> Function �[36mcheck_create_datareader�[m

2026-04-14T12:52:02.9734037Z 19: ddsrouter | �[37;1m2026-04-14 12:52:02.972 
�[31;1m[�[37;1mSECURITY�[31;1m Error] �[37mError checking creation of local reader 
(* partition not found in rule. 
(/ddsrouter/src/fastdds/src/cpp/security/accesscontrol/Permissions.cpp:245))

After recent permission/smime updates, readers were rejected because partition constraints were missing in allow rules.

Changes

  • Added partition entries in the affected permission XMLs (security compose test generators), using:
    • <partitions><partition>*</partition></partitions>
  • Regenerated the corresponding signed permissions artifacts (*.smime) for those test cases.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.24%. Comparing base (c99abad) to head (91a6254).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   31.14%   30.24%   -0.90%     
==========================================
  Files          16       16              
  Lines         594      562      -32     
  Branches      321      298      -23     
==========================================
- Hits          185      170      -15     
+ Misses        213      205       -8     
+ Partials      196      187       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Danipiza Danipiza changed the title [#24349] Temporarily patch copied Fast DDS config example in docker test [#24349] Fix Permissions in docker tests and Temporarily Patch CMake version to 3.20 Apr 15, 2026
@Danipiza Danipiza changed the title [#24349] Fix Permissions in docker tests and Temporarily Patch CMake version to 3.20 [#24349] Add partition rules to security permissions and temporarily patch CMake version to 3.20 Apr 15, 2026
@Danipiza Danipiza changed the title [#24349] Add partition rules to security permissions and temporarily patch CMake version to 3.20 [#24349] Add partition rules to security permissions tests and temporarily patch CMake version to 3.20 Apr 15, 2026
@Danipiza Danipiza requested a review from emiliocuestaf April 15, 2026 08:20
emiliocuestaf
emiliocuestaf previously approved these changes Apr 15, 2026
Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@emiliocuestaf emiliocuestaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
Signed-off-by: danipiza <dpizarrogallego@gmail.com>
@Danipiza Danipiza force-pushed the tempfix/dockertest branch from 81ec634 to 91a6254 Compare April 15, 2026 10:33
@Danipiza Danipiza merged commit e3d3e34 into main Apr 15, 2026
20 of 21 checks passed
@Danipiza Danipiza deleted the tempfix/dockertest branch April 15, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants