Open
Conversation
I've just seen your talk at FOSDEM and you mentioned cStringIO wasn't that fast. I just recenlty did some performance testing with it and my conclusion was that it's only fast when it has to handle a lot of data/iterations. My guess is that it's due to many memory reallocations that the string_concat has to do. On my machine the "boundary" is about 200k iterations. I've made the example 1M iterations so that the speedup shows its' advantage Timing function string_concat_more(): 10 loops, best of 3: 1.94 sec per loop Timing function string_cstringio_more(): 10 loops, best of 3: 382 msec per loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've just seen your talk at FOSDEM and you mentioned cStringIO wasn't that fast. I just recenlty did some performance testing with it and my conclusion was that it's only fast when it has to handle a lot of data/iterations. My guess is that it's due to many memory reallocations that the string_concat has to do.
On my machine the "boundary" is about 200k iterations. I've made the example 1M iterations so that the speedup shows its' advantage
Timing function string_concat_more():
10 loops, best of 3: 1.94 sec per loop
Timing function string_cstringio_more():
10 loops, best of 3: 382 msec per loop