Skip to content

refine index_kv constructor #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JacksonYao287 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refine index_kv constructor #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

class HomeObjectConan(ConanFile):
name = "homeobject"
version = "4.1.5"
version = "4.1.6"

homepage = "https://github.com/eBay/HomeObject"
description = "Blob Store built on HomeStore"
Expand Down
2 changes: 1 addition & 1 deletion src/lib/blob_route.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ struct BlobRoute {
sisl::blob to_blob() const { return sisl::blob{uintptr_cast(const_cast< BlobRoute* >(this)), sizeof(*this)}; }
};

// used for gc to quickly identify all the blob in the move_to chunk
// used for gc to quickly identify all the blobs in move_to_chunk
struct BlobRouteByChunk {
// homestore::chunk_num_t == uint16_t
uint16_t chunk{0};
Expand Down
6 changes: 3 additions & 3 deletions src/lib/homestore_backend/index_kv.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class BlobRouteKey : public homestore::BtreeKey {
public:
BlobRouteKey() = default;
BlobRouteKey(const BlobRoute key) : key_(key) {}
BlobRouteKey(const BlobRouteKey& other) : BlobRouteKey(other.serialize(), true) {}
BlobRouteKey(const BlobRouteKey& other) : homestore::BtreeKey(), key_(other.key_) {}
BlobRouteKey(const homestore::BtreeKey& other) : BlobRouteKey(other.serialize(), true) {}
BlobRouteKey(const sisl::blob& b, bool copy) :
homestore::BtreeKey(), key_{*(r_cast< const BlobRoute* >(b.cbytes()))} {}
Expand Down Expand Up @@ -58,7 +58,7 @@ class BlobRouteByChunkKey : public homestore::BtreeKey {
public:
BlobRouteByChunkKey() = default;
BlobRouteByChunkKey(const BlobRouteByChunk key) : key_(key) {}
BlobRouteByChunkKey(const BlobRouteByChunkKey& other) : BlobRouteByChunkKey(other.serialize(), true) {}
BlobRouteByChunkKey(const BlobRouteByChunkKey& other) : homestore::BtreeKey(), key_(other.key_) {}
BlobRouteByChunkKey(const homestore::BtreeKey& other) : BlobRouteByChunkKey(other.serialize(), true) {}
BlobRouteByChunkKey(const sisl::blob& b, bool copy) :
homestore::BtreeKey(), key_{*(r_cast< const BlobRouteByChunk* >(b.cbytes()))} {}
Expand Down Expand Up @@ -99,7 +99,7 @@ class BlobRouteValue : public homestore::BtreeValue {
public:
BlobRouteValue() = default;
BlobRouteValue(const homestore::MultiBlkId& pbas) : pbas_(pbas) {}
BlobRouteValue(const BlobRouteValue& other) : homestore::BtreeValue() { pbas_ = other.pbas_; };
BlobRouteValue(const BlobRouteValue& other) : homestore::BtreeValue(), pbas_(other.pbas_) {};
BlobRouteValue(const sisl::blob& b, bool copy) : homestore::BtreeValue() { deserialize(b, copy); }
BlobRouteValue(const homestore::BtreeValue& other) : BlobRouteValue(other.serialize(), true) {}
virtual ~BlobRouteValue() = default;
Expand Down
Loading