refactor(envd): extract inlined request/response bodies to OpenAPI components#2932
refactor(envd): extract inlined request/response bodies to OpenAPI components#2932mishushakov wants to merge 3 commits into
Conversation
Move the inlined /init and /files/compose request bodies and the /metrics, /envs, /files/compose response bodies into reusable components/requestBodies and components/responses. Regenerated api.gen.go gains named aliases only; operation-derived types are preserved, so handlers are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit e141c54. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Code Review
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
❌ 4 Tests Failed:
View the full list of 4 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Switch the init and compose handlers (and their tests) to the new component-derived types — Init, Compose, and ComposeSuccess — instead of the operation-derived JSON body types. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Moves the inlined request and response bodies in the envd OpenAPI spec into reusable
components/requestBodies(Init,Compose) andcomponents/responses(Metrics,EnvVars,ComposeSuccess), with each operation now referencing them via$ref. Regeneratedapi.gen.gogains only named type aliases — the operation-derived types likePostInitJSONBodyare preserved, so handlers are unchanged. Verified withgo build,go vet, andgolangci-lint.🤖 Generated with Claude Code