feat(placement): allow forward-compatible CPU models for sandbox placement#2900
feat(placement): allow forward-compatible CPU models for sandbox placement#2900jakubno wants to merge 2 commits into
Conversation
…ement Allow amd64 builds on Intel family 6 with model >= 106 to run on nodes with a CPU model >= the build's model. Builder node selection keeps an exact CPU match via the new IsExactMatch method.
PR SummaryMedium Risk Overview Reviewed by Cursor Bugbot for commit 5f2e238. Bugbot is set up for automated code reviews on this repo. Configure here. |
❌ 4 Tests Failed:
View the full list of 4 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Code Review
This pull request introduces a forward-compatibility check for Intel CPUs (family 6, model >= 106) on amd64 architectures in MachineInfo.IsCompatibleWith, allowing newer CPUs to run builds designed for older ones. It also adds IsExactMatch to enforce exact CPU matching for builder nodes in GetAvailableTemplateBuilder. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Allow amd64 builds on Intel family 6 with model >= 106 to run on nodes with a CPU model >= the build's model. Builder node selection keeps an exact CPU match via the new IsExactMatch method.