Put packer build in the terraform graph by djeebus · Pull Request #2889 · e2b-dev/infra

djeebus · 2026-06-01T23:44:46Z

This simplifies the process, reduces the number of steps

this simplifies the process, reduces the number of steps

cursor · 2026-06-01T23:44:52Z

PR Summary

High Risk
Apply now runs Packer builds and rolls new images through every node pool; mis-triggers or failed builds block or reshape production cluster capacity.

Overview
Moves the e2b-orch node disk image build into the main Terraform apply path via the toowoxx/packer provider, so packer build is no longer a separate bootstrap step. Cluster node pools on AWS and GCP stop resolving “latest” AMIs/GCE image families and instead boot from the image produced in that graph (manifest output parsed into launch templates / instance templates).

Init and deploy workflows now install Packer and plugins where needed; provider Makefiles split tf-init from init and only cache plugins during init. On GCP the dedicated Packer build network Terraform root is removed in favor of the shared cluster network with IAP-scoped SSH rules for the build VM.

^{Reviewed by Cursor Bugbot for commit 2778415. Bugbot is set up for automated code reviews on this repo. Configure here.}

codecov · 2026-06-01T23:45:50Z

❌ 3 Tests Failed:

Tests completed	Failed	Passed	Skipped
2716	3	2713	7

View the full list of 3 ❄️ flaky test(s)

github.com/e2b-dev/infra/tests/integration/internal/tests/envd::TestCommandKillNextApp

Flake rate in main: 40.06% (Passed 859 times, Failed 574 times)

Stack Traces | 273s run time

=== RUN   TestCommandKillNextApp
=== PAUSE TestCommandKillNextApp
=== CONT  TestCommandKillNextApp
    process_test.go:28: Command [npx] output: event:{start:{pid:1276}}
Executing command /bin/bash in sandbox iekf2yhcarwy3b3miko8x
    process_test.go:28: Command [npx] output: event:{data:{stderr:"npm"}}
    process_test.go:28: Command [npx] output: event:{data:{stderr:" WARN exec"}}
    process_test.go:28: Command [npx] output: event:{data:{stderr:" The following package was not found and will be installed: create-next-app@16.2.7\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"Creating a new Next.js app in .../home/user/nextapp.\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"Using npm.\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"\nInitializing project with template: app-tw \n\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"\nInstalling dependencies:\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- next\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- react\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- react-dom\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"\nInstalling devDependencies:\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- @tailwindcss/postcss\n- @types/node\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- @types/react\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- @types/react-dom\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- eslint\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- eslint-config-next\n"}}
    process_test.go:28: Command [npx] output: event:{data:{stdout:"- tailwindcss\n- typescript\n\n"}}
    process_test.go:28: Command [npx] output: event:{keepalive:{}}
    process_test.go:29: 
        	Error Trace:	.../tests/envd/process_test.go:29
        	Error:      	Received unexpected error:
        	            	failed to execute command npx in sandbox inu128rubv4eqoswx2o5l: invalid_argument: protocol error: incomplete envelope: unexpected EOF
        	Test:       	TestCommandKillNextApp
--- FAIL: TestCommandKillNextApp (272.84s)

github.com/e2b-dev/infra/tests/integration/internal/tests/proxies::TestEnvdAccessTokenAutoResumeViaProxy

Flake rate in main: 40.32% (Passed 860 times, Failed 581 times)

Stack Traces | 11.2s run time

=== RUN   TestEnvdAccessTokenAutoResumeViaProxy
=== PAUSE TestEnvdAccessTokenAutoResumeViaProxy
=== CONT  TestEnvdAccessTokenAutoResumeViaProxy
    traffic_access_token_test.go:357: 
        	Error Trace:	.../tests/proxies/traffic_access_token_test.go:357
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:3002/health": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
        	Test:       	TestEnvdAccessTokenAutoResumeViaProxy
--- FAIL: TestEnvdAccessTokenAutoResumeViaProxy (11.18s)

github.com/e2b-dev/infra/tests/integration/internal/tests/proxies::TestSandboxAutoResumeViaProxy

Flake rate in main: 40.79% (Passed 858 times, Failed 591 times)

Stack Traces | 19.4s run time

=== RUN   TestSandboxAutoResumeViaProxy
=== PAUSE TestSandboxAutoResumeViaProxy
=== CONT  TestSandboxAutoResumeViaProxy
Executing command ls in sandbox ita1wlofglqgf73s2omk7
    auto_resume_test.go:97: [Status code: 502] Response body: {"sandboxId":"i0j7l1pg7h0tu8qt9ii7m","message":"The sandbox is running but port is not open","port":8000,"code":502}
    auto_resume_test.go:116: 
        	Error Trace:	.../tests/proxies/auto_resume_test.go:116
        	Error:      	Received unexpected error:
        	            	Get "http://localhost:3002": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
        	Test:       	TestSandboxAutoResumeViaProxy
--- FAIL: TestSandboxAutoResumeViaProxy (19.43s)

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

gemini-code-assist

Code Review

The fileset call in packer-image.tf matches all files in the Packer directory, including manifest.json which is updated at the end of every Packer build. This creates a perpetual diff loop where every successful build modifies manifest.json, changing the files hash and triggering another rebuild on the next Terraform run. Filtering out manifest.json from the file dependencies list prevents this rebuild loop.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

# Conflicts: # iac/provider-aws/nomad-cluster-disk-image/Makefile # iac/provider-gcp/.terraform.lock.hcl # iac/provider-gcp/nomad-cluster-disk-image/Makefile # iac/provider-gcp/nomad-cluster-disk-image/main.pkr.hcl # iac/provider-gcp/nomad-cluster-disk-image/main.tf

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bc127b2a0c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c9087e2d45

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0647a29b49

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 20b6d0fcac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 2778415. Configure here.}

cursor · 2026-06-03T23:10:14Z

+	# e2b-orch node image itself is built by the packer_image resource during the regular
+	# `make plan && make apply` (Terraform drives Packer via the toowoxx/packer provider).
+	@ $(MAKE) -C nomad-cluster-disk-image init
+


apply-init skips Packer plugin install

Medium Severity

apply-init only applies module.init, but a full apply now runs the packer_image resource and needs the Packer CLI plus provider plugins on the machine. init still runs nomad-cluster-disk-image init; apply-init does not, so a path of apply-init then plan/apply (as in deploy-infra locally, without the composite action’s Packer steps) can fail when Packer builds the node image.

Additional Locations (1)

iac/provider-aws/Makefile#L116-L119

^{Reviewed by Cursor Bugbot for commit 2778415. Configure here.}

put packer build in the terraform graph

ef505cd

this simplifies the process, reduces the number of steps

cla-bot Bot added the cla-signed label Jun 1, 2026

gemini-code-assist Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread iac/provider-gcp/packer-image.tf

cursor Bot reviewed Jun 1, 2026

View reviewed changes

Comment thread iac/provider-gcp/packer-image.tf

djeebus added 3 commits June 1, 2026 17:00

simplify, maybe?

e319c9f

don't change on manifest.json changes

7161ef6

Merge branch 'main' into add-packer-to-terraform

153a939

djeebus marked this pull request as ready for review June 2, 2026 01:49

djeebus requested review from ValentaTomas, dobrac and jakubno as code owners June 2, 2026 01:49

cursor Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread iac/provider-gcp/packer-image.tf

claude Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread iac/provider-gcp/nomad-cluster-disk-image/main.pkr.hcl Outdated

Comment thread Makefile

dobrac approved these changes Jun 2, 2026

View reviewed changes

integrate packer with aws terraform

3fb869a

cursor Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread Makefile

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread Makefile

djeebus added 2 commits June 2, 2026 12:12

clean up

ffc8045

protect packer while it's building

c9087e2

chatgpt-codex-connector Bot reviewed Jun 2, 2026

View reviewed changes

Comment thread iac/provider-aws/modules/nodepool-api/main.tf Outdated

djeebus added 2 commits June 3, 2026 10:56

remove unused provider

2835892

Merge remote-tracking branch 'origin/main' into add-packer-to-terraform

0647a29

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread iac/provider-aws/packer-image.tf Outdated

Comment thread iac/provider-gcp/packer-image.tf

get rid of unuseful variables, locals, data, overrides

d826dff

cursor Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread iac/provider-gcp/packer-image.tf

Comment thread iac/provider-aws/packer-image.tf Outdated

cursor Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread iac/provider-aws/packer-image.tf Outdated

must install/init packer when deploying infra

1110170

djeebus added 3 commits June 3, 2026 14:38

pass nomad_version/consul_version into packer

358b158

only one source of default versions per cloud

23d6c33

move packer vars up to the aws/gcp roots

20b6d0f

cursor Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread iac/provider-aws/packer-image.tf Outdated

chatgpt-codex-connector Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread iac/provider-gcp/nomad-cluster-disk-image/main.pkr.hcl

djeebus added 3 commits June 3, 2026 15:51

trigger rebuilds when variables change

9c7c41d

Merge remote-tracking branch 'origin/main' into add-packer-to-terraform

6a338f6

make variable changes obvious

2778415

cursor Bot reviewed Jun 3, 2026

View reviewed changes

Conversation

djeebus commented Jun 1, 2026

Uh oh!

cursor Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

codecov Bot commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 3 Tests Failed:

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jun 3, 2026

Choose a reason for hiding this comment

apply-init skips Packer plugin install

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor Bot commented Jun 1, 2026 •

edited

Loading

codecov Bot commented Jun 1, 2026 •

edited

Loading