feat(dashboard-api): add template tags handlers#2885
Open
drankou wants to merge 15 commits into
Open
Conversation
❌ 4 Tests Failed:
View the full list of 4 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
Using a sentinel value of only one hour in the future for the initial cursor timestamp can cause assignments with timestamps further in the future to be silently omitted from the first page of results. A far-future timestamp sentinel, such as year 9999, should be used instead to ensure all future-dated assignments are correctly included.
drankou
force-pushed
the
template-dashboard-enhancements-versioning-and-storage-usage-eng-3771
branch
from
13fcbd8 to
0e9a92c
Compare
drankou
requested review from
ValentaTomas,
ben-fornefeld,
dobrac and
jakubno
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
drankou
force-pushed
the
template-dashboard-enhancements-versioning-and-storage-usage-eng-3771
branch
from
def15d4 to
352818c
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 352818c727
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the dashboard-api read endpoints powering the per-template detail view: single-template read (with latest ready build + versioning/storage fields) and tag-grouped assignment history with keyset pagination, search, and sort.
Endpoints
/templates/{templateID}/templates/{templateID}/tags/groups/templates/{templateID}/tags/count/templates/{templateID}/tags/exists/templates/{templateID}/tags/{tag}/assignmentsPagination & sort
sort ∈ {latest_desc (default), latest_asc, name_asc, name_desc}, cursor{sort}|{ts}|{tag}(rejected on sort mismatch).tagsLimit ≤ 100, per-tagassignmentLimit ≤ 25.assigned_at|assignment_id,limit ≤ 100.^[a-z0-9._-]{0,64}$, case-insensitive substring on tag.