fix(nfsproxy): only increment unmounts counter on successful chroot close#2882
Open
AdaAibaby wants to merge 2 commits into
Open
fix(nfsproxy): only increment unmounts counter on successful chroot close#2882AdaAibaby wants to merge 2 commits into
AdaAibaby wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the chroot unmounts counter is not incremented if unmounting fails during network release, and introduces a unit test to verify this behavior. There are no review comments or issues to address, and I have no feedback to provide.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1e6afcaa6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OnNetworkRelease incremented [nfs.chroot.unmounts] unconditionally, even when [chroot.Close()] returned an error. This meant the difference between [nfs.chroot.mounts] and [nfs.chroot.unmounts] — which is supposed to reflect the number of active mount namespaces — was silently understated whenever a close failed, masking mount namespace leaks in metrics and alerting.
Fix by skipping the counter increment via continue when Close() returns an error. The warning log and map cleanup are unaffected.
A unit test is added to nfs_test.go that injects one successful and one failing Close() call and asserts the counter is incremented exactly once.
/cc @jakubno