fix: auth redirect query encoding#332
Open
drankou wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix auth redirect message handling so query parameters are encoded once via
URLSearchParamsinstead of manually encoding/decoding values across server and client code.This updates the email callback redirect to use the shared
encodedRedirect()helper formessageredirects, preventing craftedmessagevalues from injecting sibling query parameters.Changes
encodedRedirect()to supportmessageredirects.URLSearchParamshandle redirect query encoding directly.redirect(...?message=${message}...)calls withencodedRedirect('message', ...).decodeURIComponent(...)calls from auth/account message rendering./api/auth/email-callback.Closes #255