during sdk release check not just source code but dep files#72
Merged
Conversation
jakubno
requested changes
Mar 25, 2025
Member
jakubno
left a comment
jakubno
left a comment
There was a problem hiding this comment.
I think there's an issue with package after update, because the package.json, pyproject.toml with the new versions are commited after the release, so there will be always a change for last released package(s)
sitole
force-pushed
the
fixed-release-process-for-deps-changes
branch
from
bb9b8f1 to
b7da3e1
Compare
sitole
force-pushed
the
fixed-release-process-for-deps-changes
branch
from
3c03f19 to
4b6d968
Compare
Member
Author
|
CI Run with demo action that is using this new script to decide if package should be release. |
jakubno
approved these changes
Mar 26, 2025
This was referenced Mar 27, 2025
jakubno
pushed a commit
to e2b-dev/E2B
that referenced
this pull request
Mar 27, 2025
Inspired by original change in code-interpreter release process e2b-dev/code-interpreter#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing issue with skipped release when there are just deps updated (#71)