Fix regex literals starting with equals#36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Regex literals whose pattern starts with
=are valid in expression positions, but the parser rejects them before reading the regex body.Those should parse and evaluate as regex literals, while compound assignment such as
a /= bshould still parse as assignment.Fix
Allow
=as the first regex pattern character when the/token is parsed in a prefix-expression position. The existing left-operand check still leaves division and/=assignment handling to their operator parsers.Add focused regex feature coverage for
replace(/=/g, ...)andreplace(/=>/g, ...).Validation
node --input-type=module -e 'import { parse } from "./subscript.js"; import "./feature/regex.js"; console.log(JSON.stringify(parse("x.replace(/=/g, \\\"\\\")"))); console.log(JSON.stringify(parse("x.replace(/=>/g, \\\":\\\")"))); console.log(JSON.stringify(parse("a /= b")))'node --import ./test/https-loader.js test/feature/regex.js