Fix regex literal left brace parsing#35
Closed
davejcameron wants to merge 1 commit into
Closed
Conversation
davejcameron
force-pushed
the
dc.regex-literal-left-brace
branch
from
6beb3d0 to
a162198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Regex literals may contain a left brace that is not a repeat quantifier in non-unicode mode.
That should evaluate to
true, while valid repeat quantifiers such as/a{2}/should continue to work.Fix
Add focused regex feature coverage for preserving a literal left brace in regex source alongside a valid
{2}quantifier. The regex parser keeps the pattern source forRegExpevaluation, so this guards against treating every{as a quantifier boundary.Validation
node --import ./test/https-loader.js test/feature/regex.jspnpm run buildpnpm test(fails on existing unicode scaling stack overflows and networked perf fetch checks)