Skip to content

Fixed ItemAction type to work along with all next router #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mil4n0r merged 2 commits into from
Nov 12, 2025
Merged

Fixed ItemAction type to work along with all next router #2332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1870d0a
Fixed ItemAction type for next router
Mil4n0r Nov 12, 2025
65dd77f
Merge branch 'master' into Mil4n0r/fix_routing_problem
PelayoFelgueroso Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/lib/src/base-menu/ItemAction.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import DxcIcon from "../icon/Icon";
import { TooltipWrapper } from "../tooltip/Tooltip";
import { useItemAction } from "./useItemAction";

const Action = styled.button<{
const Action = styled.a<{
depthLevel: ItemActionProps["depthLevel"];
selected: ItemActionProps["selected"];
displayGroupLines: boolean;
Expand Down Expand Up @@ -79,7 +79,7 @@ const Control = styled.span`
`;

const ItemAction = memo(
forwardRef<HTMLButtonElement, ItemActionProps>((props, ref) => {
forwardRef<HTMLAnchorElement, ItemActionProps>((props, ref) => {
const {
hasTooltip,
modifiedBadge,
Expand Down
2 changes: 1 addition & 1 deletion packages/lib/src/base-menu/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type MenuItemProps = {
item: ItemWithId | GroupItemWithId;
depthLevel?: number;
};
type ItemActionProps = ButtonHTMLAttributes<HTMLButtonElement> & {
type ItemActionProps = ButtonHTMLAttributes<HTMLAnchorElement> & {
badge?: Item["badge"];
collapseIcon?: ReactNode;
depthLevel: number;
Expand Down