Skip to content

New header redesigned #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PelayoFelgueroso merged 29 commits into from
Nov 17, 2025
Merged

New header redesigned #2328

PelayoFelgueroso merged 29 commits into from
Nov 17, 2025

Conversation

@Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Nov 10, 2025 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
New header redesigned.

@Jialecl Jialecl changed the title Jialecl/new header New header redesigned Nov 12, 2025
Jialecl added 21 commits November 12, 2025 08:51
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
8b80b45 
…eact into jialecl/new_header
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
8151c81 
…eact into jialecl/new_header
@Jialecl
Added callback type to sideContent + tests and improved responsiveness
d7f68f3
@Jialecl
Merge branch 'master' of https://github.com/dxc-technology/halstack-r…
f62e2c0 
…eact into jialecl/new_header
@Jialecl
Header responsive testing, documentation and implementation in website
d5b4248
@Jialecl
Header accessibility test
f423691
@Jialecl
Trying to fix storybook interaction exception
ed16f2a
@Jialecl
Title added to button
f9bb5e2
@Jialecl
accessibility test correctly named
0546382
@Jialecl
title added to buttons in test
c2a305d
@Jialecl
addin rules exceptions
c8a6f61
@Jialecl
adding title to missing title in header
55a0c2e
@Jialecl
changing userEvent to storybook's one
d919166
@Jialecl
adding wait to render menu
d9b5760
@Jialecl
trying to fix inconsistencies in actions
3469d39
@Jialecl
adding steps to test
214988b
@Jialecl
Trying to improve inconsistencies in the test
235ed9f
@Jialecl
changing actions to tabs
c814b76
@Jialecl
added settimeout
5226a0a
@Jialecl
increasing wait
942adb3
@Jialecl
additional wait time
2f9c341
@Jialecl Jialecl marked this pull request as ready for review November 13, 2025 14:08
PelayoFelgueroso
PelayoFelgueroso reviewed Nov 14, 2025
View reviewed changes
PelayoFelgueroso
PelayoFelgueroso reviewed Nov 14, 2025
View reviewed changes
@PelayoFelgueroso PelayoFelgueroso merged commit 9bcd585 into master Nov 17, 2025
5 checks passed
@PelayoFelgueroso PelayoFelgueroso deleted the jialecl/new_header branch November 17, 2025 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PelayoFelgueroso PelayoFelgueroso PelayoFelgueroso approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jialecl @PelayoFelgueroso