Skip to content

Reimplement ActionIcon and Add to Avatar Primary & Secondary text #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jialecl merged 38 commits into from
Oct 30, 2025
Merged

Reimplement ActionIcon and Add to Avatar Primary & Secondary text #2312

Jialecl merged 38 commits into from
Oct 30, 2025

Conversation

@PelayoFelgueroso
Copy link
Collaborator

@PelayoFelgueroso PelayoFelgueroso commented Oct 15, 2025 •
edited
Loading

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Reimplement new ActionIcon component and refactor Avatar using it, also add primaryText and secondaryText props to Avatar component.

@Mil4n0r Mil4n0r self-requested a review October 15, 2025 09:31
@Mil4n0r Mil4n0r self-assigned this Oct 15, 2025
@PelayoFelgueroso
Add person as default icon for avatar, remove default icon form Gorgo…
03037d0 
…rito, and removed unused const from Tabs types
Mil4n0r
Mil4n0r previously requested changes Oct 15, 2025
View reviewed changes
@PelayoFelgueroso
Rename Gorgorito to ActionIcon and remove past ActionIcon
45fc6fd
@PelayoFelgueroso
Fix test errors
40b6021
@PelayoFelgueroso
Remove outline when :focus-visible
1977b3f
@PelayoFelgueroso
Display actionIcon as button when onClick is passed
33008b7
@PelayoFelgueroso
Fix TextInput tests related to ActionIcon and DateInput
826700a
@PelayoFelgueroso
Fix styles when rendered as button
ea79015
@PelayoFelgueroso
Fix NumberInput test errors
7a1f528
@PelayoFelgueroso
Fix Select tests
ee0ccc0
@PelayoFelgueroso
Add DxcActionIcon instead of ActionIcon to Chip and Header
523174e
@PelayoFelgueroso
Add ransparentPrimary to color prop types of ActionIcon to display th…
a51e17a 
…e icon with transparent bg and primary color icon
@PelayoFelgueroso
Display only transparentPrimary on DxcActionsCell when component isn'…
8de651a 
…t disabled
@PelayoFelgueroso
Fix Dialog Test errors
0f39909
@PelayoFelgueroso
Fix ActionIcon unconsistencies in height
ec02b0a
@PelayoFelgueroso
Changed outline for border when ActionIcon is focused
348530f
@PelayoFelgueroso
Fix outline when ActionIcon is focused
bdb465c
@PelayoFelgueroso
Merge branch 'master' into PelayoFelgueroso/gorgorito
15c756d
@PelayoFelgueroso
Fix Dialog stories changes
383caf6
@PelayoFelgueroso
Merge branch 'PelayoFelgueroso/gorgorito' of https://github.com/dxc-t…
8103fc9 
…echnology/halstack-react into PelayoFelgueroso/gorgorito
@PelayoFelgueroso
Add comment
4852366
@PelayoFelgueroso
Add reducedOutline prop and remove unnecesary TooltipWrapper
4b49589
@PelayoFelgueroso
Fix DataGrid tests
756a016
@PelayoFelgueroso
Changed html tags to Avatar Label & Sublabel
258bf31
@PelayoFelgueroso PelayoFelgueroso changed the title Add Gorgorito and Add to Avatar Primary & Secondary text Reimplement ActionIcon and Add to Avatar Primary & Secondary text Oct 20, 2025
@PelayoFelgueroso PelayoFelgueroso marked this pull request as ready for review October 22, 2025 06:58
@Jialecl Jialecl dismissed Mil4n0r’s stale review October 30, 2025 10:46

He is OOO right now.

@Jialecl Jialecl merged commit 453cfa2 into master Oct 30, 2025
5 checks passed
@Jialecl Jialecl deleted the PelayoFelgueroso/gorgorito branch October 30, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jialecl Jialecl Jialecl approved these changes

@Mil4n0r Mil4n0r Mil4n0r left review comments

Assignees

@Mil4n0r Mil4n0r

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@PelayoFelgueroso @Jialecl @Mil4n0r