Skip to content

Changed how the preview is loaded to improve CSP compatibility #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PelayoFelgueroso merged 2 commits into from
Sep 17, 2025
Merged

Changed how the preview is loaded to improve CSP compatibility #2286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e20a05d
Changed how the preview is loaded to improve CSP compatibility
Jialecl Sep 17, 2025
9757698
Fix to mock correctly the file preview
Jialecl Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/lib/src/file-input/FileInput.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ import { fireEvent, render, waitFor } from "@testing-library/react";
import userEvent from "@testing-library/user-event";
import DxcFileInput from "./FileInput";

const file1 = new File(["file1"], "file1.png", { type: "image/png" });
const file1 = new File([new Uint8Array([137, 80, 78, 71])], "file1.png", {
type: "image/png",
});
const file2 = new File(["file2"], "file2.txt", {
type: "text/plain",
});
Expand All @@ -17,6 +19,9 @@ const allFiles = [
];

describe("FileInput component tests", () => {
beforeAll(() => {
global.URL.createObjectURL = jest.fn(() => "blob:mock-url");
});
test("Renders with correct labels and helper text in file mode", () => {
const callbackFile = jest.fn();
const { getByText } = render(
Expand Down Expand Up @@ -208,7 +213,7 @@ describe("FileInput component tests", () => {
expect(callbackFile).toHaveBeenCalledWith([
{
file: file1,
preview: "data:image/png;base64,ZmlsZTE=",
preview: "blob:mock-url",
},
{
error: "Error message",
Expand Down Expand Up @@ -307,7 +312,7 @@ describe("FileInput component tests", () => {
expect(callbackFile).toHaveBeenCalledWith([
{
file: file1,
preview: "data:image/png;base64,ZmlsZTE=",
preview: "blob:mock-url",
},
{
error: "Error message",
Expand All @@ -334,6 +339,7 @@ describe("FileInput component tests", () => {
maxSize={20000}
value={allFiles}
callbackFile={callbackFile}
showPreview
/>
);
await waitFor(() => {
Expand All @@ -343,7 +349,7 @@ describe("FileInput component tests", () => {
const inputFile = getByLabelText("File input label");
fireEvent.change(inputFile, { target: { files: [newFile] } });
expect(callbackFile).toHaveBeenCalledWith([
{ file: file1, preview: "data:image/png;base64,ZmlsZTE=" },
{ file: file1, preview: "blob:mock-url" },
{
error: "Error message",
file: file2,
Expand Down
8 changes: 1 addition & 7 deletions packages/lib/src/file-input/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,7 @@ export const getFilePreview = async (file: File): Promise<string> => {
if (file.type.includes("video")) return "filled_movie";
else if (file.type.includes("audio")) return "music_video";
else if (file.type.includes("image")) {
return new Promise<string>((resolve) => {
const reader = new FileReader();
reader.readAsDataURL(file);
reader.onload = (e) => {
resolve(e.target?.result as string);
};
});
return Promise.resolve(URL.createObjectURL(file));
} else return "draft";
};

Expand Down