Skip to content

Emotion and next.js compatibility #2266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mil4n0r merged 3 commits into from
Jul 31, 2025
Merged

Emotion and next.js compatibility #2266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e5c50fd
Emotion and next.js compatibility
Jialecl Jul 30, 2025
90acceb
Datagrid warning alert removed
Jialecl Jul 31, 2025
85a3eed
redundant types removed from package
Jialecl Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/website/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/// <reference types="next/image-types/global" />

// NOTE: This file should not be edited
// see https://nextjs.org/docs/pages/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/pages/api-reference/config/typescript for more information.
5 changes: 4 additions & 1 deletion apps/website/next.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ module.exports = {
return config;
},
reactStrictMode: true,
compiler: {
emotion: true,
},
assetPrefix:
process.env.NODE_ENV === "production"
? `/halstack/${process.env.NEXT_PUBLIC_SITE_VERSION?.split(".")[0]}`
Expand All @@ -25,6 +28,6 @@ module.exports = {
"@cloudscape-design/components",
"@cloudscape-design/component-toolkit",
"@cloudscape-design/theming-runtime",
"react-data-grid",
"@dxc-technology/halstack-react",
],
};
2 changes: 1 addition & 1 deletion apps/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"@emotion/styled": "^11.14.0",
"@radix-ui/react-popover": "^1.0.7",
"cross-env": "^7.0.3",
"next": "^14.2.30",
"next": "^15.4.5",
"raw-loader": "^4.0.2",
"react": "^18",
"react-color": "^2.19.3",
Expand Down
6 changes: 0 additions & 6 deletions apps/website/screens/components/data-grid/DataGridPageLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,6 @@ const DataGridPageHeading = ({ children }: { children: ReactNode }) => {
<PageHeading>
<DxcFlex direction="column" gap="var(--spacing-gap-xl)">
<ComponentHeading name="Data Grid" />
<DxcAlert
title="Issues"
semantic="warning"
message={{ text: "There are known styling issues with sortable columns when used in a NextJS app." }}
closable={false}
/>
<DxcParagraph>
The datagrid component is used to display and manage large sets of data in a tabular format, allowing users
to sort, filter, and interact with the data efficiently.
Expand Down
Loading